Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix goodput calculation in msak-client #36

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Fix goodput calculation in msak-client #36

merged 2 commits into from
Jan 11, 2024

Conversation

robertodauria
Copy link
Contributor

@robertodauria robertodauria commented Jan 10, 2024 •
edited
Loading

  • Fix goodput computation (denominator is 1e6 not 1024*1024)
  • Remove fixed-interval emit loop and align output with incoming messages

This change is Reviewable

@robertodauria robertodauria changed the title Fix goodput calculation Fix goodput calculation in msak-client Jan 10, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7481776943

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 70.296%
Totals Coverage Status
Change from base Build 7480605258: 0.3%
Covered Lines: 878
Relevant Lines: 1249
💛 - Coveralls

stephen-soltesz
stephen-soltesz approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@robertodauria robertodauria merged commit e8e5455 into main Jan 11, 2024
7 checks passed
@robertodauria robertodauria deleted the fix-goodput-calc branch January 11, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephen-soltesz stephen-soltesz stephen-soltesz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertodauria @coveralls @stephen-soltesz