Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require -streams to be between 1 and 4 in every client #42

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Require -streams to be between 1 and 4 in every client #42

merged 1 commit into from
Jan 17, 2024

Conversation

robertodauria
Copy link
Contributor

@robertodauria robertodauria commented Jan 17, 2024 •
edited
Loading

Closes #41

This change is Reviewable

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7557504839

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.216%
Totals Coverage Status
Change from base Build 7504079297: 0.0%
Covered Lines: 877
Relevant Lines: 1249
💛 - Coveralls

stephen-soltesz
stephen-soltesz approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@robertodauria robertodauria merged commit f3bfdb8 into main Jan 17, 2024
7 checks passed
@robertodauria robertodauria deleted the limit-max-streams branch January 17, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephen-soltesz stephen-soltesz stephen-soltesz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reference clients should limit max streams
3 participants
@robertodauria @coveralls @stephen-soltesz