Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix design document link #46

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Fix design document link #46

merged 1 commit into from
Jun 13, 2024

Conversation

robertodauria
Copy link
Contributor

@robertodauria robertodauria commented Jun 13, 2024

The existing link doesn't seem to give access unless the users have edit permissions on the document. This one works even if logged out from any Google account.


This change is Reviewable

@coveralls
Copy link

coveralls commented Jun 13, 2024

Pull Request Test Coverage Report for Build 9502011323

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.291%

Totals Coverage Status
Change from base Build 7816634244: 0.0%
Covered Lines: 883
Relevant Lines: 1293

💛 - Coveralls

Copy link
Contributor

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@robertodauria robertodauria merged commit acac33d into main Jun 13, 2024
7 checks passed
@robertodauria robertodauria deleted the fix/design-doc-link branch June 13, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants