Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve plain text message #120

Merged
merged 1 commit into from
May 28, 2019
Merged

Improve plain text message #120

merged 1 commit into from
May 28, 2019

Conversation

pboothe
Copy link
Contributor

@pboothe pboothe commented May 28, 2019 •
edited by stephen-soltesz
Loading

This change is Reviewable

stephen-soltesz
stephen-soltesz approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @stephen-soltesz)

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 698

  • 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 71.791%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ndt-server.go 0 8 0.0%
Totals Coverage Status
Change from base Build 691: -0.2%
Covered Lines: 1331
Relevant Lines: 1854
💛 - Coveralls

@pboothe pboothe merged commit c14db90 into master May 28, 2019
@pboothe pboothe deleted the improve-default-message branch May 28, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephen-soltesz stephen-soltesz stephen-soltesz approved these changes

Assignees
No one assigned
Labels
1 Closed current Story
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pboothe @coveralls @stephen-soltesz