Rewrite upload using download code #148
Conversation
This diff is yak shaving functional to implement #70.
Pull Request Test Coverage Report for Build 859
💛 - Coveralls |
| @@ -24,7 +24,7 @@ docker build . -t ndt-server | |||
| prepare the runtime environment | |||
|
|
|||
| ```bash | |||
| install -d certs data | |||
| install -d certs datadir | |||
There was a problem hiding this comment.
I changed the name because data now contains Go code. It may be bad to suggest storing data with a default command line in a place where there is also Go code, because one may be tempted to rm -rf it.
| @@ -0,0 +1,23 @@ | |||
| // Package closer implements the WebSocket closer. | |||
There was a problem hiding this comment.
Factored out code to allow sharing it.
| @@ -1,63 +0,0 @@ | |||
| // Package receiver implements the counter-flow messages receiver. | |||
There was a problem hiding this comment.
Renamed (unclear to me why it's not shown as a renamed and slightly changed file)
Conflicts: ndt7/upload/upload.go
There was a problem hiding this comment.
Reviewed 5 of 9 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @bassosimone and @pboothe)
ndt7/receiver/receiver.go, line 69 at r2 (raw file):
} func start(
Weird formatting. Is this how go fmt did it after you put it all on one line? Because the rule is: do it the way go fmt does it.
ndt7/receiver/receiver.go, line 93 at r2 (raw file):
// StartUploadReceiver is like StartDownloadReceiver except that it // tolerates incoming binary messages, which are indeeed sent to cause
remove 'indeed'
ndt7/measurer/measurer.go, line 1 at r2 (raw file):
// Package measurer contains the measurer. Its job is to collect metrics // from a socket connection and return them for consumption.
// Package measurer collects metrics from a socket connection and returns them for consumption.
There was a problem hiding this comment.
Reviewable status:
ndt7/receiver/receiver.go, line 69 at r2 (raw file):
Previously, pboothe (Peter Boothe) wrote…
Weird formatting. Is this how
go fmtdid it after you put it all on one line? Because the rule is: do it the waygo fmtdoes it.
As discussed in another PR, go fmt accepts this format. I'm going to apply the 100 chars-ish rule to decide whether to keep it wrapped or unwrap it.
ndt7/receiver/receiver.go, line 93 at r2 (raw file):
Previously, pboothe (Peter Boothe) wrote…
remove 'indeed'
Done.
ndt7/measurer/measurer.go, line 1 at r2 (raw file):
Previously, pboothe (Peter Boothe) wrote…
// Package measurer contains the measurer. Its job is to collect metrics // from a socket connection and return them for consumption.
// Package measurer collects metrics from a socket connection and returns them for consumption.
Done.
This diff is yak shaving functional to implement #70. Another improvement in sight that this PR will facilitate is writing unit tests, since the code has been unified and there's less to test.
This change is