-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full stack dockerfile #187
Conversation
Also sets up UUIDs appropriately
Pull Request Test Coverage Report for Build 1024
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! with two questions in one comment.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @gfr10598 and @pboothe)
fullstack/Dockerfile, line 27 at r1 (raw file):
# You can add further arguments to ndt-server, all the other commands are fixed. # Prometheus metrics for tcp-info and traceroute-caller can be found on ports # 9001 and 9002.
what about metrics for ndt-server?
Also make note that 9001 and 9002 come from the start.sh script.
Cleaned up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @gfr10598)
fullstack/Dockerfile, line 27 at r1 (raw file):
Previously, gfr10598 (Gregory Russell) wrote…
what about metrics for ndt-server?
Also make note that 9001 and 9002 come from the start.sh script.
Done. Changed to 9991 and 9992 to reflect the default value of 9990.
This will allow others to run everything.
This change is