Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full stack dockerfile #187

Merged
merged 7 commits into from
Sep 24, 2019
Merged

Add full stack dockerfile #187

merged 7 commits into from
Sep 24, 2019

Conversation

pboothe
Copy link
Contributor

@pboothe pboothe commented Sep 23, 2019

This will allow others to run everything.


This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented Sep 23, 2019

Pull Request Test Coverage Report for Build 1024

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 75.416%

Totals Coverage Status
Change from base Build 1012: 0.5%
Covered Lines: 1540
Relevant Lines: 2042

💛 - Coveralls

Copy link
Contributor

@gfr10598 gfr10598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! :lgtm: with two questions in one comment.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @gfr10598 and @pboothe)


fullstack/Dockerfile, line 27 at r1 (raw file):

# You can add further arguments to ndt-server, all the other commands are fixed.
# Prometheus metrics for tcp-info and traceroute-caller can be found on ports
# 9001 and 9002.

what about metrics for ndt-server?
Also make note that 9001 and 9002 come from the start.sh script.

Copy link
Contributor Author

@pboothe pboothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @gfr10598)


fullstack/Dockerfile, line 27 at r1 (raw file):

Previously, gfr10598 (Gregory Russell) wrote…

what about metrics for ndt-server?
Also make note that 9001 and 9002 come from the start.sh script.

Done. Changed to 9991 and 9992 to reflect the default value of 9990.

@pboothe pboothe merged commit 3d6229c into master Sep 24, 2019
@pboothe pboothe deleted the add-full-stack-dockerfile branch September 24, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants