Attempts to fix a small race condition in setting that.results.c2sRate. #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1261
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to resolve issue #281.
Test was done here:
https://ndt-iupui-mlab1-lga0t.mlab-sandbox.measurement-lab.org/static/widget.html
This was tested by logging into the ndt-server container on that node (mlab1-lga0t) and manually modifying
html/ndt-browser-client.jsin the running instance. Previously this bug would manifest within 4 or 5 runs. With this modification I was unable to trigger the bug in 10 or 15 runs.The bug is identifiable by clicking on the "Advanced" tab and finding a floating point value for
c2sRate, which should always be an integer (the server only sends an integer).This change is