Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ndt7test package for creating an ndt7 server for unit tests #319

Merged
merged 7 commits into from
Sep 10, 2020
Merged

Add ndt7test package for creating an ndt7 server for unit tests #319

merged 7 commits into from
Sep 10, 2020

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Sep 9, 2020 •
edited by robertodauria
Loading

This change adds a new package, ndt7test with function NewNDT7Server that creates an ndt7 test server for unit testing.

This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented Sep 9, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1419

  • 27 of 27 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 81.999%
Totals Coverage Status
Change from base Build 1413: 0.6%
Covered Lines: 1731
Relevant Lines: 2111
💛 - Coveralls

@stephen-soltesz stephen-soltesz mentioned this pull request Sep 9, 2020
Merged
gfr10598
gfr10598 approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@gfr10598 gfr10598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @gfr10598)

@stephen-soltesz stephen-soltesz merged commit 8da06dc into master Sep 10, 2020
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-testserver branch September 10, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfr10598 gfr10598 gfr10598 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephen-soltesz @coveralls @gfr10598