Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken build from go version upgrade #346

Merged
merged 16 commits into from
Jan 31, 2022

Conversation

cristinaleonr
Copy link
Contributor

@cristinaleonr cristinaleonr commented Jan 28, 2022

  • Using Uber's goleak package to fix failing test to detect leaked goroutines in main().

  • Replacing use of string() with fmt.Sprint() to fix the following build error:
    ndt7/receiver/receiver.go:40: conversion from receiverKind (int) to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)

This change is Reviewable

Copy link
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@cristinaleonr cristinaleonr merged commit 0539d90 into master Jan 31, 2022
@cristinaleonr cristinaleonr deleted the sandbox-cristinaleon-fix-build branch January 31, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants