Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zone delegation for autojoin.measurement-lab.org. #335

Merged
merged 2 commits into from
May 16, 2024

Conversation

robertodauria
Copy link
Contributor

@robertodauria robertodauria commented May 15, 2024

This adds the autojoin zone delegations for autojoin.measurement-lab.org (#326 and #325 are previous PRs adding zone delegation for sandbox/staging).

See here for the zone's configuration.


This change is Reviewable

Copy link
Contributor

@nkinkade nkinkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: with one small cleanup request.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @robertodauria)


formats/v2/zones/measurement-lab.org.zone.jsonnet line 46 at r1 (raw file):

                     IN     NS      ns-cloud-a3.googledomains.com.
                     IN     NS      ns-cloud-a4.googledomains.com.
    ; Delegate mlab-oti subdomain to staging Cloud DNS servers.

While you are in here, could you change this comment to read correctly, should be mlab-oti to production (not staging) servers.

@robertodauria robertodauria merged commit e2e1a6a into main May 16, 2024
3 checks passed
@robertodauria robertodauria deleted the sandbox-roberto-update-measurementlab-zone branch May 16, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants