Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds round 3 MIGs for MIG migration #339

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Adds round 3 MIGs for MIG migration #339

merged 1 commit into from
Jul 18, 2024

Conversation

nkinkade
Copy link
Contributor

@nkinkade nkinkade commented Jul 18, 2024

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @nkinkade)


sites/cmh02.jsonnet line 5 at r1 (raw file):

sitesDefault {
  name: 'cmh02',
  annotations+: {

some sites use probability 0.5, some use the default - are both correct?

Copy link
Contributor Author

@nkinkade nkinkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @stephen-soltesz)


sites/cmh02.jsonnet line 5 at r1 (raw file):

Previously, stephen-soltesz (Stephen Soltesz) wrote…

some sites use probability 0.5, some use the default - are both correct?

While you were on leave, I set all virtual sites to 50% probability that are colocated in metros that also have a physical site presence. All of these new MIGs are located in metros that also currently have at least one standalone VM. If the standalone VM had 50% probability, then I set the MIG to also have 50% probability in order to maintain this cost optimization, at least until the physical site(s) in those metros go away.

@nkinkade nkinkade merged commit 69c380a into main Jul 18, 2024
3 checks passed
@nkinkade nkinkade deleted the sandbox-kinkade branch July 18, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants