Adds new visualizations submodule #66
Conversation
The immediate use of this submodule will be to configure the proper service accounts for the grafana-public AppEngine instance.
There was a problem hiding this comment.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @nkinkade)
modules/visualizations/serviceaccounts.tf line 18 at r1 (raw file):
members = [ "serviceAccount:grafana-public@mlab-sandbox.iam.gserviceaccount.com"
The module is specifying a service account name with "mlab-sandbox". Can this be a parameter or formatted?
This commit replaces hardcoded usage of project mlab-sandbox in the granfa-public@ service account name with a variable project_id that will change automatically depending on environment.
There was a problem hiding this comment.
@stephen-soltesz: PTAL?
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @stephen-soltesz)
modules/visualizations/serviceaccounts.tf line 18 at r1 (raw file):
Previously, stephen-soltesz (Stephen Soltesz) wrote…
The module is specifying a service account name with "mlab-sandbox". Can this be a parameter or formatted?
Good catch. I replaced the static usage of "mlab-sandbox" with variable interpolation on the current project id.
There was a problem hiding this comment.
Reviewed 6 of 7 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 1 of 1 approvals obtained
The immediate use of this submodule will be to configure the proper service accounts for the grafana-public AppEngine instance. The build of this PR is adding the appropriate IAM role bindings to the new grafana-public@ service account.
This change is