Updates disk images for VMs in all projects #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change brings in updates to the write-metadata service.
This brings in the change of writing out a new "managed" metadata file in /var/local/metadata. This new file will help data users distinguish if the environment is a full, minimal or BYOS.
robertodauria
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new disk images bring in updates to the write-metadata.sh script, which will write a new metadata file at
/var/local/metadata/managedwith the content "machine". We will configure ndt-server to add this as a new-labelflag so that users of the data can identify whether the server environment is "full", "minimal" or BYOS. Depending on the environment, the content of the "managed" file will be as follows:full: "switch,machine"
minimal: "machine"
BYOS: "none"
This change is