Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow arbitrary SUBST_TAGS #43

Merged
merged 1 commit into from
Sep 12, 2018
Merged

allow arbitrary SUBST_TAGS #43

merged 1 commit into from
Sep 12, 2018

Conversation

gfr10598
Copy link
Contributor

@gfr10598 gfr10598 commented Sep 12, 2018

This introduces an environment variable to determine what tags will be substituted (using envsubst) in the app.yaml file.

This simplifies introduction of environment variables for new appengine deployments.


This change is Reviewable

@gfr10598 gfr10598 requested review from pboothe and nkinkade and removed request for pboothe September 12, 2018 14:13
Copy link
Contributor

@nkinkade nkinkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@gfr10598 gfr10598 merged commit 33d0388 into master Sep 12, 2018
@gfr10598 gfr10598 deleted the sub-all branch September 12, 2018 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants