Fix wavesynth program transfer via SPI (m-labs/pdq#20) #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my suggestion for fixing the behavior of
PDQ.program()
for the SPI version as discussed in #20.The method is split between a host (
program_host()
) and a kernel (program_kernel()
) method. The output of the former is a list of channels and a list of bytes objects, which are both stored in class variables and returned for manual handling. The latter writes the latest output by default for convenience, but can also be passed other previously stored data for flexibility.The
program()
method of the base class is overridden by a kernel method which callsprogram_host()
as an RPC.The
write_mem
method now takes bytes objects instead of list[int16], andread_mem
manipulates a bytearray object rather than a list[int16].Finally, I've adjusted the example in
examples/pdq_spi.py
accordingly and added an example for the different options to write wavesynth programs,examples/pdq_spi_waveform_writing.py