-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow ol-dev-versions as peer dependency #20
Conversation
Hmm, this doesn't indicate which the minimum version of ol is required though, so not ideal. Is there an alternative? |
This is true, generally these can be found in the I have to admit that this not ideal, I hope there is a real solution for this issue from the side of Personally, i think that very few users will use this package alongside a legacy version of |
@m-mohr Other 3rd party libraries for ol do the same, and I'm doing it also in ol-mapbox-style. Of course there's a trade-off between having the minimum compatible version in package.json and convenience of working with dev versions of OpenLayers, but after talking to @tschaub about his experiences I decided to go with |
Alright. @RobertOrthofer Could you please add the minimum required version to the README instead? |
@m-mohr I have added it to the README and made a small FAQ entry, if that's ok |
Thanks, the CI is failing though. Seems like an issue with the package-lock.json |
23053ce
to
42e7a2c
Compare
to allow usage of dev releases
Thanks, merged. |
Following the convention of
ol-mapbox-style
, this should allow projects to use the very latest dev-versions ofol
, which could include critical features.