Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow ol-dev-versions as peer dependency #20

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Conversation

RobertOrthofer
Copy link
Contributor

Following the convention of ol-mapbox-style, this should allow projects to use the very latest dev-versions of ol, which could include critical features.

@RobertOrthofer RobertOrthofer marked this pull request as ready for review July 24, 2024 13:14
@m-mohr
Copy link
Owner

m-mohr commented Sep 2, 2024

Hmm, this doesn't indicate which the minimum version of ol is required though, so not ideal. Is there an alternative?

@RobertOrthofer
Copy link
Contributor Author

This is true, generally these can be found in the README, unfortunately I am not aware of an alternative.

I have to admit that this not ideal, I hope there is a real solution for this issue from the side of npm in the near future. For now this is a judgment call about what is more important, knowing the minimum version when looking into the package.json-file, or allowing to use the latest features and fixes from ol.

Personally, i think that very few users will use this package alongside a legacy version of ol <7.5.2, while having to use the dev-Version because of some critical new feature/fix is quite common.

@ahocevar
Copy link

ahocevar commented Sep 3, 2024

@m-mohr Other 3rd party libraries for ol do the same, and I'm doing it also in ol-mapbox-style. Of course there's a trade-off between having the minimum compatible version in package.json and convenience of working with dev versions of OpenLayers, but after talking to @tschaub about his experiences I decided to go with "*".

@m-mohr
Copy link
Owner

m-mohr commented Sep 3, 2024

Alright. @RobertOrthofer Could you please add the minimum required version to the README instead?

@RobertOrthofer
Copy link
Contributor Author

@m-mohr I have added it to the README and made a small FAQ entry, if that's ok

@m-mohr
Copy link
Owner

m-mohr commented Sep 5, 2024

Thanks, the CI is failing though. Seems like an issue with the package-lock.json

@m-mohr m-mohr merged commit 0cc74f8 into m-mohr:main Sep 5, 2024
3 checks passed
@m-mohr
Copy link
Owner

m-mohr commented Sep 5, 2024

Thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants