Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with Firefox 90.0.2 ! #17

Closed
Nokia808 opened this issue Apr 6, 2021 · 9 comments
Closed

Does not work with Firefox 90.0.2 ! #17

Nokia808 opened this issue Apr 6, 2021 · 9 comments

Comments

@Nokia808
Copy link

Nokia808 commented Apr 6, 2021

Hi.

This add-on no more work with firefox 87.0 !

I'm on Fedora Linux 32 X64 bit Cinnamon edition, & my firefox installed from official Fedora repositories ....

Best.

@M-Reimer
Copy link
Owner

Can not reproduce. Please describe more in detail how you verified that it does not work.

@M-Reimer
Copy link
Owner

No further feedback --> Closing

@Nokia808
Copy link
Author

Hello ! Sorry for my delay !

Dear this add-on do not working on my Firefox version 90.0.2 installed from official repositories of my Fedora 34 X64 Cinnamon edition ! I tried multiple pages each of them support different languages .... What ever I changed language, it will remain sticky on default Firefox built-in setting which is currently en-US (1st choice). I'm Arabic tongue. I'm already added "Arabic" (ar) to my Firefox built-in setting. Language displacement priorities are:

en-Us
en
ar

I'm already added "Arabic" to the add on, so that it's code is:
ar,en-US,en

I tested:
https://aliexpress.com
https://www.france24.com
https://www.bbc.com
& many other sites with same failure result ! When I set to "Arabic" the page will appear in English (even after restarting my Firefox) !

I tried "French" with same error.

Kindly, re-open this issue & investigate about it.

@M-Reimer
Copy link
Owner

M-Reimer commented Jul 28, 2021

I'll check with the pages you suggested.

Did you try with just the Firefox language settings already (move "ar" to the top). Does it work then?

@M-Reimer M-Reimer reopened this Jul 28, 2021
@M-Reimer
Copy link
Owner

Oh. Forgot to ask: Do you use "private browsing mode" and if so: Did you allow my Add-on to run there?

@Nokia808
Copy link
Author

@M-Reimer
Hello !

  1. I'm already give your add-on permission to work in private browsing mode,
  2. this issue happening in both private & non-private modes,
  3. but it seem now that error not in your add-on ! But in the Firefox itself !! I tried to change built-in setting of my Firefox, so that preferred page language set 1st to Arabic. But same error happened as if I'm still set on English-US (original 1st choice) ! I tried to set French as 1st choice, but also same error happened & English page opened to me not French !

@Nokia808 Nokia808 changed the title Does not work with Firefox 87.0 ! Does not work with Firefox 90.0.2 ! Jul 28, 2021
@M-Reimer
Copy link
Owner

I'll check as soon as possible but for me it seems like the websites, you mentioned, just don't care about the preferred language sent by the browser.

@Nokia808
Copy link
Author

Nokia808 commented Jul 28, 2021

I tested same pages on my Android Firefox (not installed your add-on on it) & my mobile language setting is on Arabic, but web sites open on English version ! I checked "language" setting of my Android Firefox & it is on system default (which mean Arabic) !

I do not know more. But what I'm very sure from, like that I'm sure from my name, is that all these web sites were behave differently before version 87.0 of Firefox !

@M-Reimer
Copy link
Owner

M-Reimer commented Sep 3, 2021

It does work with your example https://www.france24.com/

And it will switch to "Arabic" language with the language string "ar,en-US,en". So the functionality works. It just heavily depends on the websites to correctly support it. That's also the main purpose of my Add-on. It is meant for developers to easily check theirs websites for correct language switching based on the browser language.

@M-Reimer M-Reimer closed this as completed Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants