Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decode.py: decode_msg_23 should have 'shiptype' not 'ship_type' #32

Closed
brucebookman opened this issue May 25, 2021 · 1 comment
Closed

decode.py: decode_msg_23 should have 'shiptype' not 'ship_type' #32

brucebookman opened this issue May 25, 2021 · 1 comment
Assignees
@M0r13n
Labels
bug Something isn't working

Comments

@brucebookman
Copy link

There are two different keys for ship type. Please only use one.

`
decode_msg_5 ...
'shiptype': ShipType(get_int_from_data(232, 240)),
decode_msg_19 ..
'shiptype': ShipType(get_int_from_data(232, 240)),
...
decode_msg_23 . . .
'ship_type': ShipType(get_int_from_data(114, 122))

`
@M0r13n M0r13n added the bug Something isn't working label May 28, 2021
@M0r13n M0r13n self-assigned this May 28, 2021
M0r13n added a commit that referenced this issue Jun 6, 2021
@M0r13n
Uniformly name shiptype as part of #32
d88207e
M0r13n added a commit that referenced this issue Jun 6, 2021
@M0r13n
Uniformly name shiptype as part of #32 (#34)
bf9a99f
@M0r13n
Copy link
Owner

M0r13n commented Jun 6, 2021

Done. Will be available in the next release

@M0r13n M0r13n closed this as completed Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@M0r13n M0r13n

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@M0r13n @brucebookman