Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to lock client remote on login #375

Closed
wants to merge 3 commits into from

Conversation

FapFapDragon
Copy link
Contributor

One liner to lock client controls on join. Mostly useful when NEKO_IMPLICIT_CONTROL is set.
Users joining will not be controlling but have the option.
In YAML:

NEKO_LOCKS: "remote"

Let me know if you don't like how I've done this.

Add check for volume parameter in URL before setting volume
Add option to lock controls by default
@m1k1o
Copy link
Owner

m1k1o commented Mar 14, 2024

Locks are mainly used for server-side locking. There are also missing translations for that lock:

image

As this happens only on the client side and is never synchronized with the server (the lock cannot be actually changed) I think that this is more like a GUI option rather than a new lock.

Along with configuring such settings as default volume, default keyboard we could define that it is locked by default. This would need a way how to configure client from server settings, by e.g. adding configuration json endpoint that is loading everytime when gui is started.

@FapFapDragon
Copy link
Contributor Author

Thanks for the feedback, That makes sense.

I suppose the JSON could be an option, and I didn't notice the missing translations, so good catch.

I'm going to close this pull request and may come back to this later (I really only needed this change for my groups personal instance so I can build from my fork for that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants