Domain info command response exposes a single status #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacegu
changed the title
|
Not quite sure the best solution here.
I'm tempted to go with option 1 though. |
|
For what it's worth I'd go with 1 too. |
geoffgarside
added a commit
that referenced
this pull request
Oct 16, 2014
…status Domain info command response exposes a single status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The domain info command returns zero or more statuses. Right now only the first one is exposed by the client but all of them should be returned.
This is a minor change but wouldn't be backwards compatible since
response.statusno longer returns aStringbut anArray.An alternative approach may be adding a
statusesmethod that returns all of them and leave thestatusmethod returning only the first one. I leave that up for discussion.