Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Genclean fixes #30

Merged
merged 2 commits into from
Oct 13, 2018
Merged

Genclean fixes #30

merged 2 commits into from
Oct 13, 2018

Conversation

prateek
Copy link
Collaborator

@prateek prateek commented Oct 12, 2018

No description provided.

@codecov
Copy link

codecov bot commented Oct 12, 2018 •
edited
Loading

Codecov Report

Merging #30 into master will increase coverage by 0.05%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #30      +/-   ##
=========================================
+ Coverage   52.65%   52.7%   +0.05%     
=========================================
  Files           4       4              
  Lines         716     721       +5     
=========================================
+ Hits          377     380       +3     
- Misses        323     324       +1     
- Partials       16      17       +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3414a73...96ddc4c. Read the comment docs.

benraskin92
benraskin92 reviewed Oct 13, 2018
View reviewed changes
utilities/genclean/testdata/order/example_6.go.input Outdated
@@ -0,0 +1,13 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove newline

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

benraskin92
benraskin92 approved these changes Oct 13, 2018
View reviewed changes
Copy link
Contributor

@benraskin92 benraskin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prateek prateek merged commit edd1bdd into master Oct 13, 2018
@prateek prateek deleted the prateek/genclean-fixes branch October 13, 2018 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benraskin92 benraskin92 benraskin92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prateek @benraskin92