-
Notifications
You must be signed in to change notification settings - Fork 458
/
Copy pathwrite.go
339 lines (299 loc) · 8.99 KB
/
write.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
// Copyright (c) 2019 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package ingest
import (
"context"
"sync"
"github.com/m3db/m3/src/cmd/services/m3coordinator/downsample"
"github.com/m3db/m3/src/metrics/policy"
"github.com/m3db/m3/src/query/models"
"github.com/m3db/m3/src/query/storage"
"github.com/m3db/m3/src/query/ts"
xerrors "github.com/m3db/m3x/errors"
xsync "github.com/m3db/m3x/sync"
xtime "github.com/m3db/m3x/time"
)
// DownsampleAndWriteIter is an interface that can be implemented to use
// the WriteBatch method.
type DownsampleAndWriteIter interface {
Next() bool
Current() (models.Tags, ts.Datapoints, xtime.Unit)
Reset() error
Error() error
}
// DownsamplerAndWriter is the interface for the downsamplerAndWriter which
// writes metrics to the downsampler as well as to storage in unaggregated form.
type DownsamplerAndWriter interface {
Write(
ctx context.Context,
tags models.Tags,
datapoints ts.Datapoints,
unit xtime.Unit,
overrides WriteOptions,
) error
// TODO(rartoul): Batch interface should also support downsampling rules.
WriteBatch(
ctx context.Context,
iter DownsampleAndWriteIter,
) error
Storage() storage.Storage
}
// WriteOptions contains overrides for the downsampling mapping
// rules and storage policies for a given write.
type WriteOptions struct {
DownsampleOverride bool
DownsampleMappingRules []downsample.MappingRule
WriteOverride bool
WriteStoragePolicies []policy.StoragePolicy
}
// downsamplerAndWriter encapsulates the logic for writing data to the downsampler,
// as well as in unaggregated form to storage.
type downsamplerAndWriter struct {
store storage.Storage
downsampler downsample.Downsampler
workerPool xsync.PooledWorkerPool
}
// NewDownsamplerAndWriter creates a new downsampler and writer.
func NewDownsamplerAndWriter(
store storage.Storage,
downsampler downsample.Downsampler,
workerPool xsync.PooledWorkerPool,
) DownsamplerAndWriter {
return &downsamplerAndWriter{
store: store,
downsampler: downsampler,
workerPool: workerPool,
}
}
func (d *downsamplerAndWriter) Write(
ctx context.Context,
tags models.Tags,
datapoints ts.Datapoints,
unit xtime.Unit,
overrides WriteOptions,
) error {
err := d.maybeWriteDownsampler(tags, datapoints, unit, overrides)
if err != nil {
return err
}
return d.maybeWriteStorage(ctx, tags, datapoints, unit, overrides)
}
func (d *downsamplerAndWriter) maybeWriteDownsampler(
tags models.Tags,
datapoints ts.Datapoints,
unit xtime.Unit,
overrides WriteOptions,
) error {
var (
downsamplerExists = d.downsampler != nil
// If they didn't request the mapping rules to be overridden, then assume they want the default
// ones.
useDefaultMappingRules = !overrides.DownsampleOverride
// If they did try and override the mapping rules, make sure they've provided at least one.
downsampleOverride = overrides.DownsampleOverride && len(overrides.DownsampleMappingRules) > 0
// Only downsample if the downsampler exists, and they either want to use the default mapping
// rules, or they're trying to override the mapping rules and they've provided at least one
// override to do so.
shouldDownsample = downsamplerExists && (useDefaultMappingRules || downsampleOverride)
)
if shouldDownsample {
// TODO(rartoul): MetricsAppender has a Finalize() method, but it does not actually reuse many
// resources. If we can pool this properly we can get a nice speedup.
appender, err := d.downsampler.NewMetricsAppender()
if err != nil {
return err
}
for _, tag := range tags.Tags {
appender.AddTag(tag.Name, tag.Value)
}
if tags.Opts.IDSchemeType() == models.TypeGraphite {
// NB(r): This is gross, but if this is a graphite metric then
// we are going to set a special tag that means the downsampler
// will write a graphite ID. This should really be plumbed
// through the downsampler in general, but right now the aggregator
// does not allow context to be attached to a metric so when it calls
// back the context is lost currently.
appender.AddTag(downsample.MetricsOptionIDSchemeTagName,
downsample.GraphiteIDSchemeTagValue)
}
var appenderOpts downsample.SampleAppenderOptions
if downsampleOverride {
appenderOpts = downsample.SampleAppenderOptions{
Override: true,
OverrideRules: downsample.SamplesAppenderOverrideRules{
MappingRules: overrides.DownsampleMappingRules,
},
}
}
samplesAppender, err := appender.SamplesAppender(appenderOpts)
if err != nil {
return err
}
for _, dp := range datapoints {
err := samplesAppender.AppendGaugeSample(dp.Value)
if err != nil {
return err
}
}
appender.Finalize()
}
return nil
}
func (d *downsamplerAndWriter) maybeWriteStorage(
ctx context.Context,
tags models.Tags,
datapoints ts.Datapoints,
unit xtime.Unit,
overrides WriteOptions,
) error {
var (
storageExists = d.store != nil
useDefaultStoragePolicies = !overrides.WriteOverride
)
if !storageExists {
return nil
}
if storageExists && useDefaultStoragePolicies {
return d.store.Write(ctx, &storage.WriteQuery{
Tags: tags,
Datapoints: datapoints,
Unit: unit,
Attributes: storage.Attributes{
MetricsType: storage.UnaggregatedMetricsType,
},
})
}
var (
wg sync.WaitGroup
multiErr xerrors.MultiError
errLock sync.Mutex
)
for _, p := range overrides.WriteStoragePolicies {
p := p // Capture for goroutine.
wg.Add(1)
d.workerPool.Go(func() {
err := d.store.Write(ctx, &storage.WriteQuery{
Tags: tags,
Datapoints: datapoints,
Unit: unit,
Attributes: storage.Attributes{
// Assume all overridden storage policies are for aggregated namespaces.
MetricsType: storage.AggregatedMetricsType,
Resolution: p.Resolution().Window,
Retention: p.Retention().Duration(),
},
})
if err != nil {
errLock.Lock()
multiErr = multiErr.Add(err)
errLock.Unlock()
}
wg.Done()
})
}
wg.Wait()
return multiErr.FinalError()
}
func (d *downsamplerAndWriter) WriteBatch(
ctx context.Context,
iter DownsampleAndWriteIter,
) error {
var (
wg = sync.WaitGroup{}
multiErr xerrors.MultiError
errLock sync.Mutex
addError = func(err error) {
errLock.Lock()
multiErr = multiErr.Add(err)
errLock.Unlock()
}
)
if d.store != nil {
// Write unaggregated. Spin up all the background goroutines that make
// network requests before we do the synchronous work of writing to the
// downsampler.
for iter.Next() {
wg.Add(1)
tags, datapoints, unit := iter.Current()
d.workerPool.Go(func() {
err := d.store.Write(ctx, &storage.WriteQuery{
Tags: tags,
Datapoints: datapoints,
Unit: unit,
Attributes: storage.Attributes{
MetricsType: storage.UnaggregatedMetricsType,
},
})
if err != nil {
addError(err)
}
wg.Done()
})
}
}
// Iter does not need to be synchronized because even though we use it to spawn
// many goroutines above, the iteration is always synchronous.
resetErr := iter.Reset()
if resetErr != nil {
addError(resetErr)
}
if d.downsampler != nil && resetErr == nil {
err := d.writeAggregatedBatch(iter)
if err != nil {
addError(err)
}
}
wg.Wait()
return multiErr.LastError()
}
func (d *downsamplerAndWriter) writeAggregatedBatch(
iter DownsampleAndWriteIter,
) error {
appender, err := d.downsampler.NewMetricsAppender()
if err != nil {
return err
}
var opts downsample.SampleAppenderOptions
for iter.Next() {
appender.Reset()
tags, datapoints, _ := iter.Current()
for _, tag := range tags.Tags {
appender.AddTag(tag.Name, tag.Value)
}
samplesAppender, err := appender.SamplesAppender(opts)
if err != nil {
return err
}
for _, dp := range datapoints {
err := samplesAppender.AppendGaugeSample(dp.Value)
if err != nil {
return err
}
}
}
appender.Finalize()
if err := iter.Error(); err != nil {
return err
}
return nil
}
func (d *downsamplerAndWriter) Storage() storage.Storage {
return d.store
}