Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf *DB*: Sample Write Method Timers #1057

Merged
merged 1 commit into from
Oct 13, 2018
Merged

Conversation

prateek
Copy link
Collaborator

@prateek prateek commented Oct 9, 2018

No description provided.

@codecov
Copy link

codecov bot commented Oct 9, 2018

Codecov Report

Merging #1057 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1057      +/-   ##
==========================================
+ Coverage   77.36%   77.41%   +0.04%     
==========================================
  Files         545      545              
  Lines       46065    46068       +3     
==========================================
+ Hits        35640    35663      +23     
+ Misses       8169     8154      -15     
+ Partials     2256     2251       -5
Flag Coverage Δ
#aggregator 81.59% <ø> (ø) ⬆️
#collector 59.23% <ø> (ø) ⬆️
#dbnode 81.35% <100%> (+0.08%) ⬆️
#m3em 73.21% <ø> (ø) ⬆️
#m3ninx 75.25% <ø> (ø) ⬆️
#m3nsch 51.19% <ø> (ø) ⬆️
#query 63.49% <ø> (ø) ⬆️
#x 75.1% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f59502c...bfe6494. Read the comment docs.

Copy link
Contributor

@richardartoul richardartoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:stamp: Please make sure we have an issue tracking a better solution for this

@prateek
Copy link
Collaborator Author

prateek commented Oct 12, 2018

Sure: #1076

Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prateek prateek merged commit 4a10b8e into master Oct 13, 2018
@prateek prateek deleted the prateek/misc/issue-896 branch October 13, 2018 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants