Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-calculate reasonable values for WriteBatchPoolSize and return batches to the pool even if commitlog queue is full #1236

Merged
merged 2 commits into from
Dec 10, 2018

Conversation

richardartoul
Copy link
Contributor

@richardartoul richardartoul commented Dec 8, 2018

  • Auto-calculate WriteBatchPool size based on commitlog queue size
  • Return WriteBatch to pool even if commitlog queue is full
  • Fix db.IsOverloaded() calculations

@codecov
Copy link

codecov bot commented Dec 8, 2018

Codecov Report

Merging #1236 into master will decrease coverage by <.1%.
The diff coverage is 45.4%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1236     +/-   ##
========================================
- Coverage    70.8%   70.7%   -0.1%     
========================================
  Files         748     748             
  Lines       63055   63078     +23     
========================================
+ Hits        44644   44647      +3     
- Misses      15533   15546     +13     
- Partials     2878    2885      +7
Flag Coverage Δ
#aggregator 81.6% <ø> (-0.1%) ⬇️
#cluster 85.6% <ø> (ø) ⬆️
#collector 78.4% <ø> (ø) ⬆️
#dbnode 80.8% <45.4%> (-0.1%) ⬇️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 75.2% <ø> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 18.2% <ø> (ø) ⬆️
#msg 74.9% <ø> (ø) ⬆️
#query 60.3% <ø> (ø) ⬆️
#x 76% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4386243...30b8d53. Read the comment docs.

Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardartoul richardartoul merged commit 4dc0ef1 into master Dec 10, 2018
@robskillington robskillington deleted the ra/write-batch-pool-calc branch December 10, 2018 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants