Add endpoint to set database bootstrappers dynamically #1239
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1239 +/- ##
========================================
- Coverage 70.7% 70.7% -0.1%
========================================
Files 748 750 +2
Lines 63078 63136 +58
========================================
+ Hits 44644 44672 +28
- Misses 15553 15573 +20
- Partials 2881 2891 +10
Continue to review full report at Codecov.
|
| return | ||
| } | ||
|
|
||
| array := new(commonpb.StringArrayProto) |
There was a problem hiding this comment.
you tested this right? It will allocate the underlying slice properly?
There was a problem hiding this comment.
Yeah, this works. Unmarshal handles that.
| value, err := store.Get(kvconfig.BootstrapperKey) | ||
| if err != nil { | ||
| logger.Error("unable to get kv key", zap.Any("error", err)) | ||
| xhttp.Error(w, err, http.StatusInternalServerError) |
There was a problem hiding this comment.
is this a 500? Seems like its basically the equivalent of a 404 or even a 200 with a null response or something
There was a problem hiding this comment.
I'll check if its ErrNotFound.
| return nil, xhttp.NewParseError(fmt.Errorf("no values"), http.StatusBadRequest) | ||
| } | ||
|
|
||
| if err := dbconfig.ValidateBootstrappersOrder(array.Values); err != nil { |
| tags: | ||
| - "M3DB Database" | ||
| - "M3DB" | ||
| summary: "Configure M3DB set bootstrappers dynamically, which override config" |
There was a problem hiding this comment.
"Dynamically override the bootstrappers configured in M3DBs node-level configuration"
| tags: | ||
| - "M3DB Database" | ||
| - "M3DB" | ||
| summary: "Configure M3DB get bootstrappers dynamically, which override config" |
There was a problem hiding this comment.
"Retrieve the dynamically configured bootstrappers override, if any."
No description provided.