[docker] add image for setting recommended sysctls #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schallert
force-pushed
the
schallert/sysctl_setter
branch
from
ae75e35
to
74a4a48
Compare
Codecov Report
@@ Coverage Diff @@
## master #1436 +/- ##
========================================
+ Coverage 70.8% 70.9% +<.1%
========================================
Files 836 836
Lines 71507 71507
========================================
+ Hits 50696 50701 +5
+ Misses 17514 17511 -3
+ Partials 3297 3295 -2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1436 +/- ##
=========================================
- Coverage 70.9% 59.5% -11.4%
=========================================
Files 836 571 -265
Lines 71507 48466 -23041
=========================================
- Hits 50709 28876 -21833
+ Misses 17506 17283 -223
+ Partials 3292 2307 -985
Continue to review full report at Codecov.
|
schallert
force-pushed
the
schallert/sysctl_setter
branch
from
74a4a48
to
3ba3f17
Compare
schallert
changed the title
This PR provides users with a docker image and Kubernetes DaemonSet that will set the host's sysctls to our recommended settings. We try to be careful about this and recommend pinning to a docker image SHA so that the content is immutable (i.e. someone who controlled our Quay repo couldn't run arbitrary root containers on hosts that have the image).
schallert
force-pushed
the
schallert/sysctl_setter
branch
from
3ba3f17
to
9e5f822
Compare
prateek
approved these changes
Mar 12, 2019
|
@schallert Should we add a comment somewhere that explains all the places you need to update values if you want to change the recommended defaults? Need to update constants in code, constants in documentation, and also this script now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides users with a docker image and Kubernetes DaemonSet that
will set the host's sysctls to our recommended settings. We try to be
careful about this and recommend pinning to a docker image SHA so that
the content is immutable (i.e. someone who controlled our Quay repo
couldn't run arbitrary root containers on hosts that have the image).