Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 0.8.0 migration warning + update kernel configuration documentation + update automatic M3DB limits warnings #1499

Merged
merged 6 commits into from
Mar 26, 2019

Conversation

richardartoul
Copy link
Contributor

No description provided.

@richardartoul richardartoul requested review from schallert, arnikola and benraskin92 and removed request for arnikola March 26, 2019 19:38
docker/sysctl-setter/Dockerfile Show resolved Hide resolved
docker/sysctl-setter/Dockerfile Outdated Show resolved Hide resolved
@@ -31,12 +31,29 @@ To set this value permanently, update the `vm.swappiness` setting in `/etc/sysct
## rlimits
M3DB also can use a high number of files and we suggest setting a high max open number of files due to per partition fileset volumes.

On Linux you can set a high limit for maximum number of open files in `/etc/security/limits.conf`:
On Linux you can set a high limit for the maximum number of open files for a specific user in `/etc/security/limits.conf`:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to mention that when running under systemd this vals will probably be ignored and maybe point to some of the GH issues or docs we found. Let me know if you can't find some refs I can help look

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a comment should be enough and then tell them to see the systemd details below

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/etc/security/limits.conf only works for PAM stuff, let's not mislead users. It must be set in systemd unit, upstart config or the init script itself.

docs/operational_guide/kernel_configuration.md Outdated Show resolved Hide resolved
docs/operational_guide/kernel_configuration.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@schallert schallert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardartoul richardartoul merged commit 9e488c0 into master Mar 26, 2019
@richardartoul richardartoul deleted the ra/0.8.0-warning branch March 26, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants