[m3snch] kube script: add warmup between starts #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We see some weird behavior when all of the clients try to start at once, let's add a warmup.
schallert
force-pushed
the
schallert/m3nsch_k8s_warmup
branch
from
b0e6e4b
to
f8a181b
Compare
| @@ -34,6 +36,19 @@ fi | |||
|
|
|||
| AGENT_ENDPOINTS=$(get_endpoints) | |||
|
|
|||
| if [[ "$#" -eq 1 && "$1" == "start" ]]; then | |||
| ( | |||
| IFS="," | |||
There was a problem hiding this comment.
Is this being used? I'm confused
There was a problem hiding this comment.
Yup! This is some bash-foo that when we iterate over the comma-separated $AGENT_ENDPOINTS will treat , as the separator (it's usually , \t, or \n). https://bash.cyberciti.biz/guide/$IFS
richardartoul
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see some weird behavior when all of the clients try to start at once,
let's add a warmup.