-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[query] Propagate Limit settings for remote reads #1685
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1685 +/- ##
========================================
+ Coverage 71.8% 71.9% +<.1%
========================================
Files 970 970
Lines 81265 81276 +11
========================================
+ Hits 58419 58460 +41
+ Misses 19012 18983 -29
+ Partials 3834 3833 -1
Continue to review full report at Codecov.
|
4 similar comments
Codecov Report
@@ Coverage Diff @@
## master #1685 +/- ##
========================================
+ Coverage 71.8% 71.9% +<.1%
========================================
Files 970 970
Lines 81265 81276 +11
========================================
+ Hits 58419 58460 +41
+ Misses 19012 18983 -29
+ Partials 3834 3833 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1685 +/- ##
========================================
+ Coverage 71.8% 71.9% +<.1%
========================================
Files 970 970
Lines 81265 81276 +11
========================================
+ Hits 58419 58460 +41
+ Misses 19012 18983 -29
+ Partials 3834 3833 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1685 +/- ##
========================================
+ Coverage 71.8% 71.9% +<.1%
========================================
Files 970 970
Lines 81265 81276 +11
========================================
+ Hits 58419 58460 +41
+ Misses 19012 18983 -29
+ Partials 3834 3833 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1685 +/- ##
========================================
+ Coverage 71.8% 71.9% +<.1%
========================================
Files 970 970
Lines 81265 81276 +11
========================================
+ Hits 58419 58460 +41
+ Misses 19012 18983 -29
+ Partials 3834 3833 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
Limit was not correctly propagated for remote reads, which could OOM clusters when using the Prometheus remote read endpoints.
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: