Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Propagate Limit settings for remote reads #1685

Merged
merged 1 commit into from
May 31, 2019

Conversation

arnikola
Copy link
Collaborator

What this PR does / why we need it:

Limit was not correctly propagated for remote reads, which could OOM clusters when using the Prometheus remote read endpoints.

Does this PR introduce a user-facing and/or backwards incompatible change?:

Users who set a low limit but relied on the prom read endpoints may see less data returned, but this is unlikely, and is easily fixed by updating the limit in coordinator settings.

Does this PR require updating code package or user-facing documentation?:

NONE

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #1685 into master will increase coverage by <.1%.
The diff coverage is 59%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1685     +/-   ##
========================================
+ Coverage    71.8%   71.9%   +<.1%     
========================================
  Files         970     970             
  Lines       81265   81276     +11     
========================================
+ Hits        58419   58460     +41     
+ Misses      19012   18983     -29     
+ Partials     3834    3833      -1
Flag Coverage Δ
#aggregator 82.4% <ø> (ø) ⬆️
#cluster 85.7% <ø> (ø) ⬆️
#collector 63.9% <ø> (ø) ⬆️
#dbnode 80% <ø> (ø) ⬆️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74.1% <ø> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.6% <ø> (ø) ⬆️
#msg 74.7% <ø> (ø) ⬆️
#query 66.3% <59%> (-0.1%) ⬇️
#x 86% <ø> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68580c0...fe7b3e8. Read the comment docs.

4 similar comments
@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #1685 into master will increase coverage by <.1%.
The diff coverage is 59%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1685     +/-   ##
========================================
+ Coverage    71.8%   71.9%   +<.1%     
========================================
  Files         970     970             
  Lines       81265   81276     +11     
========================================
+ Hits        58419   58460     +41     
+ Misses      19012   18983     -29     
+ Partials     3834    3833      -1
Flag Coverage Δ
#aggregator 82.4% <ø> (ø) ⬆️
#cluster 85.7% <ø> (ø) ⬆️
#collector 63.9% <ø> (ø) ⬆️
#dbnode 80% <ø> (ø) ⬆️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74.1% <ø> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.6% <ø> (ø) ⬆️
#msg 74.7% <ø> (ø) ⬆️
#query 66.3% <59%> (-0.1%) ⬇️
#x 86% <ø> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68580c0...fe7b3e8. Read the comment docs.

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #1685 into master will increase coverage by <.1%.
The diff coverage is 59%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1685     +/-   ##
========================================
+ Coverage    71.8%   71.9%   +<.1%     
========================================
  Files         970     970             
  Lines       81265   81276     +11     
========================================
+ Hits        58419   58460     +41     
+ Misses      19012   18983     -29     
+ Partials     3834    3833      -1
Flag Coverage Δ
#aggregator 82.4% <ø> (ø) ⬆️
#cluster 85.7% <ø> (ø) ⬆️
#collector 63.9% <ø> (ø) ⬆️
#dbnode 80% <ø> (ø) ⬆️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74.1% <ø> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.6% <ø> (ø) ⬆️
#msg 74.7% <ø> (ø) ⬆️
#query 66.3% <59%> (-0.1%) ⬇️
#x 86% <ø> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68580c0...fe7b3e8. Read the comment docs.

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #1685 into master will increase coverage by <.1%.
The diff coverage is 59%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1685     +/-   ##
========================================
+ Coverage    71.8%   71.9%   +<.1%     
========================================
  Files         970     970             
  Lines       81265   81276     +11     
========================================
+ Hits        58419   58460     +41     
+ Misses      19012   18983     -29     
+ Partials     3834    3833      -1
Flag Coverage Δ
#aggregator 82.4% <ø> (ø) ⬆️
#cluster 85.7% <ø> (ø) ⬆️
#collector 63.9% <ø> (ø) ⬆️
#dbnode 80% <ø> (ø) ⬆️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74.1% <ø> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.6% <ø> (ø) ⬆️
#msg 74.7% <ø> (ø) ⬆️
#query 66.3% <59%> (-0.1%) ⬇️
#x 86% <ø> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68580c0...fe7b3e8. Read the comment docs.

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #1685 into master will increase coverage by <.1%.
The diff coverage is 59%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1685     +/-   ##
========================================
+ Coverage    71.8%   71.9%   +<.1%     
========================================
  Files         970     970             
  Lines       81265   81276     +11     
========================================
+ Hits        58419   58460     +41     
+ Misses      19012   18983     -29     
+ Partials     3834    3833      -1
Flag Coverage Δ
#aggregator 82.4% <ø> (ø) ⬆️
#cluster 85.7% <ø> (ø) ⬆️
#collector 63.9% <ø> (ø) ⬆️
#dbnode 80% <ø> (ø) ⬆️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74.1% <ø> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.6% <ø> (ø) ⬆️
#msg 74.7% <ø> (ø) ⬆️
#query 66.3% <59%> (-0.1%) ⬇️
#x 86% <ø> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68580c0...fe7b3e8. Read the comment docs.

Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnikola arnikola merged commit 7a89168 into master May 31, 2019
@arnikola arnikola deleted the arnikola/limit-remote-reads branch May 31, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants