Avoid references to released bytes when taking a snapshot of an encoder #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobolog
approved these changes
Dec 18, 2016
cw9
pushed a commit
that referenced
this pull request
Oct 14, 2018
…e applicable (#194) * Add MarkAllShardsAvailable to mark initializing shards available where applicable * Use the algorithm API where possible
cw9
pushed a commit
that referenced
this pull request
Oct 14, 2018
cw9
pushed a commit
that referenced
this pull request
Oct 16, 2018
cw9
pushed a commit
that referenced
this pull request
Oct 16, 2018
cw9
pushed a commit
that referenced
this pull request
Oct 16, 2018
…e applicable (#194) * Add MarkAllShardsAvailable to mark initializing shards available where applicable * Use the algorithm API where possible
cw9
pushed a commit
that referenced
this pull request
Oct 16, 2018
…e applicable (#194) * Add MarkAllShardsAvailable to mark initializing shards available where applicable * Use the algorithm API where possible
cw9
pushed a commit
that referenced
this pull request
Oct 16, 2018
…e applicable (#194) * Add MarkAllShardsAvailable to mark initializing shards available where applicable * Use the algorithm API where possible
prateek
pushed a commit
that referenced
this pull request
Apr 7, 2019
prateek
pushed a commit
that referenced
this pull request
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @kobolog @xichen2020
This is to avoid the known case of
Stream()taking a reference to a bytes slice that is returned to the pool fromostream.gowhen appending bytes withpool.AppendByte(..., bytesPool).In the future we can build a dependency graph here using contexts to avoid copying, for now this will workaround the current free after use issues.