[dbnode] Fix overzealous log message for missing schema with non-protobuf namespace #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benraskin92
approved these changes
Oct 21, 2019
| zap.String("currentSchema", curSchemaID)) | ||
| merr = merr.Add(fmt.Errorf("can not update namespace(%v) schema to empty", metadata.ID().String())) | ||
| if !curSchemaNone { | ||
| // NB(r): Only interpret this as a warning/error if already had a schema |
| @@ -33,35 +33,53 @@ func UpdateSchemaRegistry(newNamespaces Map, schemaReg SchemaRegistry, log *zap. | |||
| schemaUpdates := newNamespaces.Metadatas() | |||
| merr := xerrors.NewMultiError() | |||
There was a problem hiding this comment.
Maybe name this multiErr?
Codecov Report
@@ Coverage Diff @@
## master #2013 +/- ##
========================================
- Coverage 71.7% 69.3% -2.5%
========================================
Files 1007 999 -8
Lines 86272 86288 +16
========================================
- Hits 61932 59840 -2092
- Misses 20162 22187 +2025
- Partials 4178 4261 +83
Continue to review full report at Codecov.
|
notbdu
force-pushed
the
r/namespace-registry-update
branch
2 times, most recently
from
d19d29b
to
b10442c
Compare
notbdu
force-pushed
the
r/namespace-registry-update
branch
from
ea5a454
to
4360c02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This was confusing as an operator since this is not an error state, it is the regular expected case when operating a DB node with namespaces that are not configured with protobuf schemas.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: