Fixes for IDs #202
Merged
Fixes for IDs #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xichen2020
approved these changes
Dec 20, 2016
| @@ -78,6 +78,7 @@ func (v *id) Hash() Hash { | |||
| // access to the hash field, compute and cache it. | |||
| if atomic.CompareAndSwapInt32(&v.flag, int32(invalid), int32(pending)) { | |||
| v.hash = hash(v.data) | |||
| atomic.StoreInt32(&v.flag, int32(computed)) | |||
cw9
pushed a commit
that referenced
this pull request
Oct 14, 2018
cw9
pushed a commit
that referenced
this pull request
Oct 16, 2018
cw9
pushed a commit
that referenced
this pull request
Oct 16, 2018
prateek
pushed a commit
that referenced
this pull request
Apr 7, 2019
prateek
pushed a commit
that referenced
this pull request
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where ID hashes are never cached. It also reverts IDs to be immutable again.