Shareable Vagrant Scripts && Azure NVMe Disk Support #2107
Conversation
| @@ -3,15 +3,33 @@ | |||
| # Use with Ubuntu 16.x+ | |||
| set -xe | |||
|
|
|||
| apt-get update | |||
|
|
|||
| DOCKER_CONFIG_FILE=daemon.json | |||
There was a problem hiding this comment.
Does this file exist already? Ah I see it https://github.com/m3db/m3/blob/e0a408895c6d98b20a42c8687295dc194ffbe0ea/scripts/vagrant/docker/daemon.json
|
This looks great, nice work! Will definitely nice having the NVMe's too as we push the nodes hard during benchmarking. |
|
|
||
| # Mount nvme devices (if present) | ||
| apt-get install -y mhddfs | ||
| DISKS=$(lsblk | grep nvme | awk '{ print $1 }') |
There was a problem hiding this comment.
Would it be slightly more portable if we made this grep -i nvme in case another provider names it with capitals somewhere in the disk name?
Codecov Report
@@ Coverage Diff @@
## master #2107 +/- ##
========================================
- Coverage 72.4% 72.3% -0.1%
========================================
Files 1010 1010
Lines 86849 86849
========================================
- Hits 62882 62860 -22
- Misses 19781 19797 +16
- Partials 4186 4192 +6
Continue to review full report at Codecov.
|
What this PR does / why we need it:
Adds shareable scripts for ssh/tunneling to vagrant boxes. Supports azure nvme disks.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: