[query] api: Respect env+zone headers in topic #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this in a test cluster and was able to create topics for an environment other than the one the coordinator was configured with 👍 . |
schallert
force-pushed
the
schallert/topic_env_override
branch
2 times, most recently
from
d6c9e31
to
4393859
Compare
We recently updated our Buildkite stack. The new version of the agents doesn't come with netcat installed, which we use in our integration tests. "Install" it if necessary.
schallert
force-pushed
the
schallert/topic_env_override
branch
from
4393859
to
789ea4d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2159 +/- ##
========================================
Coverage ? 61.4%
========================================
Files ? 807
Lines ? 78644
Branches ? 0
========================================
Hits ? 48324
Misses ? 26760
Partials ? 3560
Continue to review full report at Codecov.
|
commit 9f05f58 Author: Matt Schallert <mattschallert@gmail.com> Date: Thu Feb 20 21:25:25 2020 -0500 undo debug commit 8f8f832 Author: Matt Schallert <mattschallert@gmail.com> Date: Thu Feb 20 20:08:56 2020 -0500 try undo addr change commit dd83408 Author: Matt Schallert <mattschallert@gmail.com> Date: Thu Feb 20 18:27:50 2020 -0500 another way commit 99a2dfb Author: Matt Schallert <mattschallert@gmail.com> Date: Thu Feb 20 17:45:21 2020 -0500 fix ips commit 3d90281 Author: Matt Schallert <mattschallert@gmail.com> Date: Thu Feb 20 17:35:43 2020 -0500 fix nc addrs
schallert
force-pushed
the
schallert/topic_env_override
branch
from
789ea4d
to
25f8907
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: We previously had not been taking the
Cluster-Environment-NameandCluster-Zone-Nameheaders into account in the topic handler. Users rely on these for namespace and placement handlers. This updates the topic handlers to respect them as well.Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: