Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube] Add CAP_SYS_RESOURCE to m3db container #2174

Merged
merged 3 commits into from
Feb 27, 2020

Conversation

schallert
Copy link
Collaborator

What this PR does / why we need it: Updates Kubernetes manifests to ensure M3DB containers can raise their permissions.

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #2174 into master will decrease coverage by 6.9%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2174     +/-   ##
========================================
- Coverage    72.3%   65.3%   -7.0%     
========================================
  Files        1016    1012      -4     
  Lines       87981   87240    -741     
========================================
- Hits        63627   57015   -6612     
- Misses      20092   26396   +6304     
+ Partials     4262    3829    -433     
Flag Coverage Δ
#aggregator 82.0% <ø> (ø) ⬆️
#cluster 74.1% <ø> (-11.3%) ⬇️
#collector 82.8% <ø> (ø) ⬆️
#dbnode 78.2% <ø> (-1.2%) ⬇️
#m3em 68.8% <ø> (-5.7%) ⬇️
#m3ninx 71.1% <ø> (-3.1%) ⬇️
#m3nsch 28.4% <ø> (-22.8%) ⬇️
#metrics 17.6% <ø> (ø) ⬆️
#msg 74.8% <ø> (+1.8%) ⬆️
#query 40.9% <ø> (-27.4%) ⬇️
#x 82.6% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d6ee3...45df724. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@279af5e). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2174   +/-   ##
========================================
  Coverage          ?   70.7%           
========================================
  Files             ?    1016           
  Lines             ?   88002           
  Branches          ?       0           
========================================
  Hits              ?   62285           
  Misses            ?   21476           
  Partials          ?    4241
Flag Coverage Δ
#aggregator 82% <ø> (?)
#cluster 67.4% <ø> (?)
#collector 82.8% <ø> (?)
#dbnode 79.2% <100%> (?)
#m3em 74.4% <ø> (?)
#m3ninx 65.5% <ø> (?)
#m3nsch 51.1% <ø> (?)
#metrics 17.6% <ø> (?)
#msg 74.8% <ø> (?)
#query 68.3% <ø> (?)
#x 82.7% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279af5e...0e3523e. Read the comment docs.

Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schallert schallert merged commit d727dc9 into master Feb 27, 2020
@schallert schallert deleted the schallert/kube_manifest_secctx branch February 27, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants