[dbnode] Ensure that bootstrap.Cache is always passed by reference #2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnikola
reviewed
Oct 7, 2020
| @@ -179,7 +179,7 @@ type readNamespaceResult struct { | |||
| func (s *commitLogSource) Read( | |||
| ctx context.Context, | |||
| namespaces bootstrap.Namespaces, | |||
| cache bootstrap.Cache, | |||
| cache *bootstrap.Cache, | |||
arnikola
reviewed
Oct 7, 2020
| @@ -123,7 +123,7 @@ func newFileSystemSource(opts Options) (bootstrap.Source, error) { | |||
| func (s *fileSystemSource) AvailableData( | |||
| md namespace.Metadata, | |||
| shardTimeRanges result.ShardTimeRanges, | |||
| cache bootstrap.Cache, | |||
| cache *bootstrap.Cache, | |||
arnikola
reviewed
Oct 7, 2020
| @@ -119,7 +119,7 @@ func (s *peersSource) AvailableIndex( | |||
| func (s *peersSource) Read( | |||
| ctx context.Context, | |||
| namespaces bootstrap.Namespaces, | |||
| cache bootstrap.Cache, | |||
| cache *bootstrap.Cache, | |||
arnikola
reviewed
Oct 7, 2020
| @@ -172,15 +172,15 @@ func TestPeersSourceAvailableDataAndIndex(t *testing.T) { | |||
| require.NoError(t, sErr) | |||
|
|
|||
| runOpts := testDefaultRunOpts.SetInitialTopologyState(tc.topoState) | |||
| dataRes, err := src.AvailableData(nsMetadata, tc.shardsTimeRangesToBootstrap, cache, runOpts) | |||
| dataRes, err := src.AvailableData(nsMetadata, tc.shardsTimeRangesToBootstrap, &cache, runOpts) | |||
There was a problem hiding this comment.
nit: instead, could we have bootstrap.NewCache return a pointer?
|
Why don't we make Should also require fewer changes but maybe some validation that cache is always set. |
arnikola
reviewed
Oct 7, 2020
| @@ -236,7 +236,7 @@ func (b bootstrapProcess) Run( | |||
| namespacesRunFirst, | |||
| namespacesRunSecond, | |||
| } { | |||
| res, err := b.runPass(ctx, namespaces, cache) | |||
| res, err := b.runPass(ctx, namespaces, &cache) | |||
There was a problem hiding this comment.
nit: should get this for free if NewCache returns a pointer
Yeah that's a good idea. Will do |
nbroyles
force-pushed
the
nb/actually-use-cache-smh
branch
from
33ac1e4
to
00e4ae2
Compare
ryanhall07
approved these changes
Oct 7, 2020
nbroyles
force-pushed
the
nb/actually-use-cache-smh
branch
from
6316532
to
ac1b3ea
Compare
nbroyles
force-pushed
the
nb/actually-use-cache-smh
branch
from
85942ac
to
d2f651a
Compare
nbroyles
force-pushed
the
nb/actually-use-cache-smh
branch
from
5ee1d92
to
e0bd10c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: