Check checkpoint file writer error #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
Changes Unknown when pulling 603be14 on prateek/ns-isolation-writer-close into ** on prateek/ns-isolation**. |
robskillington
approved these changes
Sep 11, 2017
persist/fs/write.go
Outdated
| @@ -262,8 +262,11 @@ func (w *writer) writeCheckpointFile() error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| defer fd.Close() | |||
| return w.digestBuf.WriteDigestToFile(fd, w.digestFdWithDigestContents.Digest().Sum32()) | |||
| if err := w.digestBuf.WriteDigestToFile(fd, w.digestFdWithDigestContents.Digest().Sum32()); err != nil { | |||
There was a problem hiding this comment.
nit: Extract the digest calculation to line before to reduce line length and improve overall readability?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
persist/fs.Writer.Close()Making a test for this is more involved, opened #348 as a follow up.
/cc @robskillington