Add RequireNoWait header #3502
Merged
Add RequireNoWait header #3502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rallen090
force-pushed
the
ra/require-no-wait-header
branch
from
c0d9cb7
to
08d0a57
Compare
ryanhall07
reviewed
May 18, 2021
ryanhall07
reviewed
May 18, 2021
arnikola
approved these changes
May 18, 2021
| @@ -244,6 +244,7 @@ func FromRPCFetchTaggedRequest( | |||
| StartInclusive: start, | |||
| EndExclusive: end, | |||
| RequireExhaustive: req.RequireExhaustive, | |||
| RequireNoWait: req.RequireNoWait, | |||
There was a problem hiding this comment.
nit: can we get some tests for FromRPCFetchTaggedRequest->ToRPCFetchTaggedRequest and back cases to verify we don't drop these params? Same with the other convert func
There was a problem hiding this comment.
There's an integration test thankfully here, but agreed unit tests should also be added.
| @@ -37,13 +37,16 @@ func TestFixedPermits(t *testing.T) { | |||
| require.NoError(t, err) | |||
| expectedP := NewPermit(1, iOpts) | |||
| expectedP.(*permit).refCount.Inc() | |||
| p, err := fp.Acquire(ctx) | |||
| r, err := fp.Acquire(ctx) | |||
| p := r.Permit | |||
There was a problem hiding this comment.
nit: check error first in case this is nil, same for the other calls in this file
| @@ -104,6 +104,10 @@ const ( | |||
| // ensure M3 returns an error if the results set is not exhaustive. | |||
| LimitRequireExhaustiveHeader = M3HeaderPrefix + "Limit-Require-Exhaustive" | |||
|
|
|||
| // LimitRequireNoWaitHeader is the M3 header that ensures | |||
| // M3 returns an error if query execution must wait for permits. | |||
| LimitRequireNoWaitHeader = M3HeaderPrefix + "Limit-Require-NoWait" | |||
There was a problem hiding this comment.
nit: Limit-Require-No-Wait to keep consistency?
| return v, nil | ||
| } | ||
|
|
||
| if str := req.FormValue("requireNoWait"); str != "" { |
| WaitedSeriesRead int `json:"waitedSeriesRead"` | ||
| } | ||
|
|
||
| // Any returns whether any waiting occurred. |
There was a problem hiding this comment.
nit: maybe Waited has a little more context?
| @@ -58,6 +67,15 @@ type Permits interface { | |||
| Release(permit Permit) | |||
| } | |||
|
|
|||
| // AcquireResult contains metadata about acquiring a permit. | |||
There was a problem hiding this comment.
meganit: not quite metadata since it contains the permit itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add optional header to require that permits will never wait.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: