Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aggregator] Binary transform increase conditionally replaces NaN with zero #3517

Merged
merged 26 commits into from
Jun 2, 2021

Conversation

sidneyw
Copy link
Collaborator

@sidneyw sidneyw commented May 25, 2021

What this PR does / why we need it:
PR attempts to fix aggregator counter reset issue due to binary transform increase returning an empty datapoint when it encounters a NaN previous value.

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:
User facing configuration has changed in a backwards compatible way.

Adds static feature flags to the aggregator configuration for enabling prev NaN to zero conversion.

Does this PR require updating code package or user-facing documentation?:

NONE

@CLAassistant
Copy link

CLAassistant commented May 25, 2021

CLA assistant check
All committers have signed the CLA.

@sidneyw sidneyw changed the title wip - aggregator counter dips aggregator] Binary transform increase conditionally replaces NaN with zero Jun 1, 2021
@sidneyw sidneyw changed the title aggregator] Binary transform increase conditionally replaces NaN with zero [aggregator] Binary transform increase conditionally replaces NaN with zero Jun 1, 2021
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #3517 (ef4f67d) into master (af480e9) will decrease coverage by 1.7%.
The diff coverage is 4.3%.

❗ Current head ef4f67d differs from pull request most recent head 9a9c894. Consider uploading reports for the commit 9a9c894 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3517     +/-   ##
========================================
- Coverage    57.6%   55.9%   -1.8%     
========================================
  Files         548     549      +1     
  Lines       67373   61419   -5954     
========================================
- Hits        38873   34336   -4537     
+ Misses      25115   23978   -1137     
+ Partials     3385    3105    -280     
Flag Coverage Δ
aggregator 57.2% <5.7%> (-0.2%) ⬇️
cluster ∅ <ø> (∅)
collector 54.3% <ø> (ø)
dbnode 60.3% <ø> (-2.0%) ⬇️
m3em 46.4% <ø> (ø)
metrics 19.8% <0.0%> (-0.1%) ⬇️
msg 74.4% <ø> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af480e9...9a9c894. Read the comment docs.

@sidneyw sidneyw marked this pull request as ready for review June 1, 2021 18:33
Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robskillington robskillington enabled auto-merge (squash) June 1, 2021 18:56
@robskillington robskillington merged commit d051ea4 into master Jun 2, 2021
@robskillington robskillington deleted the aggregator-counter-dips branch June 2, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants