-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aggregator] Binary transform increase conditionally replaces NaN with zero #3517
Conversation
d790813
to
accd868
Compare
…explicitly parse before setting on options
…ter-dips Add feedback to move logic of parsing close to the config struct and …
Codecov Report
@@ Coverage Diff @@
## master #3517 +/- ##
========================================
- Coverage 57.6% 55.9% -1.8%
========================================
Files 548 549 +1
Lines 67373 61419 -5954
========================================
- Hits 38873 34336 -4537
+ Misses 25115 23978 -1137
+ Partials 3385 3105 -280
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
PR attempts to fix aggregator counter reset issue due to binary transform increase returning an empty datapoint when it encounters a NaN previous value.
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
User facing configuration has changed in a backwards compatible way.
Does this PR require updating code package or user-facing documentation?: