Run middleware before the custom handler if one exists #3530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if a custom handler was registered to override an existing handler, the middleware would still run before the existing handler. custom -> middleware fns -> previous Now the middleware is not added until after the custom handlers override any previous handlers. This ensures the middleware always runs first. 1. If a custom handler overrides a previous handler middleware fns -> custom -> previous 2. If a custom handler does not override anything middleware fns -> custom 3. If there is no custom handler for the route middleware fn -> previous
wesleyk
force-pushed
the
rhall-middleware-custom
branch
from
a7b0075
to
1a62ad2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if a custom handler was registered to override an existing
handler, the middleware would still run before the existing handler.
custom -> middleware fns -> previous
Now the middleware is not added until after the custom handlers override
any previous handlers. This ensures the middleware always runs first.
middleware fns -> custom -> previous
middleware fns -> custom
middleware fn -> previous
What this PR does / why we need it:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: