Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aggregator] Cap length of sample for reusal #3536

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Conversation

vdarulis
Copy link
Collaborator

@vdarulis vdarulis commented Jun 3, 2021

What this PR does / why we need it:

Reduce memory usage of sample lists that were used by very high-volume timers.
Really should just move to an array list or something, but that is more involved and needs perf testing.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


@vdarulis vdarulis requested a review from abliqo June 3, 2021 01:46
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #3536 (04883d7) into master (d051ea4) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3536     +/-   ##
========================================
- Coverage    55.9%   55.8%   -0.1%     
========================================
  Files         549     549             
  Lines       61434   61437      +3     
========================================
- Hits        34366   34307     -59     
- Misses      23966   24012     +46     
- Partials     3102    3118     +16     
Flag Coverage Δ
aggregator 57.1% <0.0%> (-0.1%) ⬇️
cluster ∅ <ø> (∅)
collector 54.3% <ø> (ø)
dbnode 60.2% <ø> (-0.1%) ⬇️
m3em 46.4% <ø> (ø)
metrics 19.8% <ø> (ø)
msg 73.9% <ø> (-0.7%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d051ea4...04883d7. Read the comment docs.

@vdarulis vdarulis enabled auto-merge (squash) June 3, 2021 13:32
@vdarulis vdarulis disabled auto-merge June 3, 2021 13:32
@vdarulis vdarulis merged commit feba416 into master Jun 3, 2021
@vdarulis vdarulis deleted the v/poolsamples branch June 3, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants