Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coordinator] Fix annotation bytes not being passed to write request #3537

Merged
merged 4 commits into from
Jun 4, 2021

Conversation

vpranckaitis
Copy link
Collaborator

What this PR does / why we need it:

Fixes coordinator not passing annotation bytes to write request

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #3537 (5f61918) into master (5f61918) will not change coverage.
The diff coverage is n/a.

❗ Current head 5f61918 differs from pull request most recent head 64df41e. Consider uploading reports for the commit 64df41e to get more accurate results

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3537   +/-   ##
======================================
  Coverage    55.8%   55.8%           
======================================
  Files         549     549           
  Lines       61437   61437           
======================================
  Hits        34341   34341           
  Misses      23990   23990           
  Partials     3106    3106           
Flag Coverage Δ
aggregator 57.1% <0.0%> (ø)
cluster ∅ <0.0%> (∅)
collector 54.3% <0.0%> (ø)
dbnode 60.3% <0.0%> (ø)
m3em 46.4% <0.0%> (ø)
metrics 19.8% <0.0%> (ø)
msg 74.4% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f61918...64df41e. Read the comment docs.

vpranckaitis and others added 2 commits June 4, 2021 15:57
@vpranckaitis vpranckaitis enabled auto-merge (squash) June 4, 2021 06:16
@vpranckaitis vpranckaitis merged commit c888faf into master Jun 4, 2021
@vpranckaitis vpranckaitis deleted the vilius/coordinator_missing_annotation branch June 4, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants