Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Fix groupByNodes to get proper first path #3640

Merged
merged 4 commits into from
Jul 31, 2021

Conversation

yyin-sc
Copy link
Collaborator

@yyin-sc yyin-sc commented Jul 31, 2021

What this PR does / why we need it:

Fix groupByNodes to get proper first path, both in normal cases and special cases like scaleToSeconds(servers.foo-2.pod1.status.500,1)

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@codecov
Copy link

codecov bot commented Jul 31, 2021

Codecov Report

Merging #3640 (af9ea71) into master (29722e7) will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3640     +/-   ##
========================================
- Coverage    56.3%   56.1%   -0.3%     
========================================
  Files         551     551             
  Lines       61868   61868             
========================================
- Hits        34872   34743    -129     
- Misses      23879   23993    +114     
- Partials     3117    3132     +15     
Flag Coverage Δ
aggregator 57.1% <ø> (ø)
cluster ∅ <ø> (∅)
collector 58.4% <ø> (ø)
dbnode 60.6% <ø> (-0.3%) ⬇️
m3em 46.4% <ø> (ø)
metrics 19.8% <ø> (ø)
msg 74.3% <ø> (-0.3%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29722e7...af9ea71. Read the comment docs.

Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robskillington robskillington merged commit d35bafe into m3db:master Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants