Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Fix Graphite substr function to handle negative indexes correctly #3647

Merged
merged 2 commits into from
Aug 5, 2021

Conversation

yyin-sc
Copy link
Collaborator

@yyin-sc yyin-sc commented Aug 3, 2021

What this PR does / why we need it:

fix graphite substr() to handle negative index better.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #3647 (1cd66d5) into master (0ab7b10) will decrease coverage by 1.3%.
The diff coverage is n/a.

❗ Current head 1cd66d5 differs from pull request most recent head 6c729bc. Consider uploading reports for the commit 6c729bc to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3647     +/-   ##
========================================
- Coverage    57.5%   56.1%   -1.4%     
========================================
  Files         551     551             
  Lines       64031   61876   -2155     
========================================
- Hits        36824   34772   -2052     
+ Misses      24012   23971     -41     
+ Partials     3195    3133     -62     
Flag Coverage Δ
aggregator 57.1% <ø> (ø)
cluster ∅ <ø> (∅)
collector 58.4% <ø> (ø)
dbnode 60.7% <ø> (-1.7%) ⬇️
m3em 46.4% <ø> (ø)
metrics 19.8% <ø> (ø)
msg 74.4% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a0dca2...6c729bc. Read the comment docs.

@robskillington robskillington changed the title [query] fix graphite substr() to handle negative index better [query] Fix graphite substr() to handle negative index better Aug 4, 2021
Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robskillington robskillington changed the title [query] Fix graphite substr() to handle negative index better [query] Fix graphite substr() to handle negative indexes correctly Aug 5, 2021
@robskillington robskillington changed the title [query] Fix graphite substr() to handle negative indexes correctly [query] Fix graphite substr function to handle negative indexes correctly Aug 5, 2021
@robskillington robskillington changed the title [query] Fix graphite substr function to handle negative indexes correctly [query] Fix Graphite substr function to handle negative indexes correctly Aug 5, 2021
@robskillington robskillington enabled auto-merge (squash) August 5, 2021 00:59
@robskillington robskillington merged commit 20010ac into m3db:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants