[query] Fix Graphite aliasByNode when sub-expr returns a pattern in an arg of fn that is itself the name of a fn #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o arg of fn that is itself the name of a fn
robskillington
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3655 +/- ##
========================================
- Coverage 56.4% 56.1% -0.3%
========================================
Files 551 551
Lines 61876 61876
========================================
- Hits 34909 34772 -137
- Misses 23854 23983 +129
- Partials 3113 3121 +8
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
robskillington
deleted the
r/fix-alias-by-node-subpattern-matching-fn-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously compiler was trying to compile any fetch or pattern that matches name of a function, this caused sub-expressions that matched the name of a function (e.g. identity) to cause aliasByNode to fail since they wouldn't compile as sub-expressions as the pattern would tried to be compiled to a function arg but would fail.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: