Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Fix Graphite compiler eagerly parsing identifier as function call and not considering pattern #3656

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

robskillington
Copy link
Collaborator

What this PR does / why we need it:

Fixes the case where Graphite compiler eagerly parses an identifier that matches a function name (i.e. max) but is actually just an identifier.

Added unit test that covers this case.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@robskillington robskillington enabled auto-merge (squash) August 12, 2021 01:02
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #3656 (e77ed4f) into master (9f82e9a) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3656   +/-   ##
======================================
  Coverage    56.1%   56.1%           
======================================
  Files         551     551           
  Lines       61876   61876           
======================================
+ Hits        34755   34767   +12     
+ Misses      23994   23979   -15     
- Partials     3127    3130    +3     
Flag Coverage Δ
aggregator 57.1% <ø> (ø)
cluster ∅ <ø> (∅)
collector 58.4% <ø> (ø)
dbnode 60.7% <ø> (+<0.1%) ⬆️
m3em 46.4% <ø> (ø)
metrics 19.8% <ø> (ø)
msg 74.2% <ø> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f82e9a...e77ed4f. Read the comment docs.

@robskillington robskillington merged commit 3372fb1 into master Aug 12, 2021
@robskillington robskillington deleted the r/fix-groupbynode-max-last-arg-aliasbymetric branch August 12, 2021 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants