Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbnode] Log numShards on topology update #3665

Merged
merged 2 commits into from
Aug 19, 2021

Conversation

linasm
Copy link
Collaborator

@linasm linasm commented Aug 18, 2021

What this PR does / why we need it:
Just a minor logging change for better visibility.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:
NONE

Does this PR require updating code package or user-facing documentation?:
NONE

@linasm linasm enabled auto-merge (squash) August 18, 2021 15:14
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #3665 (ad5a4fd) into master (ad5a4fd) will not change coverage.
The diff coverage is n/a.

❗ Current head ad5a4fd differs from pull request most recent head f799ac8. Consider uploading reports for the commit f799ac8 to get more accurate results

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3665   +/-   ##
======================================
  Coverage    56.4%   56.4%           
======================================
  Files         551     551           
  Lines       62554   62554           
======================================
  Hits        35287   35287           
  Misses      24096   24096           
  Partials     3171    3171           
Flag Coverage Δ
aggregator 57.1% <0.0%> (ø)
cluster ∅ <0.0%> (∅)
collector 58.4% <0.0%> (ø)
dbnode 60.9% <0.0%> (ø)
m3em 46.4% <0.0%> (ø)
metrics 19.8% <0.0%> (ø)
msg 74.4% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad5a4fd...f799ac8. Read the comment docs.

@linasm linasm merged commit ec10287 into master Aug 19, 2021
@linasm linasm deleted the linasm/log-nu-shards-on-topology-update branch August 19, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants