Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbnode] TestReuseStreamingWriter #3666

Merged
merged 2 commits into from
Aug 19, 2021
Merged

Conversation

linasm
Copy link
Collaborator

@linasm linasm commented Aug 18, 2021

What this PR does / why we need it:
Test case for #3664 fix.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:
NONE

Does this PR require updating code package or user-facing documentation?:
NONE

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #3666 (4525d2e) into master (ad5a4fd) will decrease coverage by 0.2%.
The diff coverage is n/a.

❗ Current head 4525d2e differs from pull request most recent head 05004d0. Consider uploading reports for the commit 05004d0 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3666     +/-   ##
========================================
- Coverage    56.4%   56.1%   -0.3%     
========================================
  Files         551     551             
  Lines       62554   61889    -665     
========================================
- Hits        35287   34760    -527     
+ Misses      24096   23997     -99     
+ Partials     3171    3132     -39     
Flag Coverage Δ
aggregator 57.1% <ø> (ø)
cluster ∅ <ø> (∅)
collector 58.4% <ø> (ø)
dbnode 60.7% <ø> (-0.3%) ⬇️
m3em 46.4% <ø> (ø)
metrics 19.8% <ø> (ø)
msg 74.2% <ø> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec10287...05004d0. Read the comment docs.

@linasm linasm merged commit 3cefcfa into master Aug 19, 2021
@linasm linasm deleted the linasm/TestReuseStreamingWriter branch August 19, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants