Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] Increment fileset volume in shard splitter #3674

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

linasm
Copy link
Collaborator

@linasm linasm commented Aug 20, 2021

What this PR does / why we need it:
Reduce the likelihood of collisions when splitting directly into a running cluster.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:
NONE

Does this PR require updating code package or user-facing documentation?:
NONE

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #3674 (bfffcc5) into master (bfffcc5) will not change coverage.
The diff coverage is n/a.

❗ Current head bfffcc5 differs from pull request most recent head f99be7d. Consider uploading reports for the commit f99be7d to get more accurate results

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3674   +/-   ##
======================================
  Coverage    56.8%   56.8%           
======================================
  Files         551     551           
  Lines       61894   61894           
======================================
  Hits        35156   35156           
  Misses      23593   23593           
  Partials     3145    3145           
Flag Coverage Δ
aggregator 61.6% <0.0%> (ø)
cluster ∅ <0.0%> (∅)
collector 58.4% <0.0%> (ø)
dbnode 60.7% <0.0%> (ø)
m3em 46.4% <0.0%> (ø)
metrics 19.7% <0.0%> (ø)
msg 74.3% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfffcc5...f99be7d. Read the comment docs.

@linasm linasm requested a review from jeromefroe August 20, 2021 11:52
@linasm linasm merged commit 4a9b7a8 into master Aug 20, 2021
@linasm linasm deleted the linasm/shard-split-increment-volume branch August 20, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants