Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aggregator] Use WaitForInterrupt to handle interrupts #3676

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

nbroyles
Copy link
Collaborator

What this PR does / why we need it:

WaitForInterrupt is the more idiomatic way for us to
handle interrupts and also more gracefully handles
a nil interruptCh.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


WaitForInterrupt is the more idiomatic way for us to
handle interrupts and also more gracefully handles
a nil interruptCh.
@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #3676 (85c2dd6) into master (93eb67b) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3676     +/-   ##
========================================
- Coverage    56.7%   56.6%   -0.1%     
========================================
  Files         551     551             
  Lines       61894   61896      +2     
========================================
- Hits        35112   35094     -18     
- Misses      23633   23647     +14     
- Partials     3149    3155      +6     
Flag Coverage Δ
aggregator 61.4% <0.0%> (-0.1%) ⬇️
cluster ∅ <ø> (∅)
collector 58.4% <ø> (ø)
dbnode 60.6% <ø> (-0.1%) ⬇️
m3em 46.4% <ø> (ø)
metrics 19.7% <ø> (ø)
msg 74.2% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93eb67b...85c2dd6. Read the comment docs.

@nbroyles nbroyles merged commit cc4e82d into master Aug 20, 2021
@nbroyles nbroyles deleted the nb/idiomatic-interrupt branch August 20, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants